Skip to content

Conversation

@V00D00-child
Copy link
Member

Description

This is a version bump for the preinstalled @metamask/message-signing-snap to v1.1.2

This latest version updates the message signing snap endowment:rpc to allow requests from a Snap and adds npm:@metamask/gator-permissions-snap to initialConnections.

Related issues

relates to: MetaMask/message-signing-snap#128
required by: MetaMask/snap-7715-permissions#84
relates to: MetaMask/metamask-extension#32521

Manual testing steps

There are no user-facing changes to test

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@V00D00-child V00D00-child added dependencies Pull requests that update a dependency file No QA Needed Apply this label when your PR does not need any QA effort. No E2E Smoke Needed no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed team-readable-permissions MetaMask Readable Permissions Team labels May 5, 2025
@socket-security
Copy link

socket-security bot commented May 5, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​message-signing-snap@​1.1.1 ⏵ 1.1.284 -210099 +195 +250

View full report

@V00D00-child V00D00-child added the release-7.46.0 Issue or pull request that will be included in release 7.46.0 label May 5, 2025
@V00D00-child V00D00-child marked this pull request as ready for review May 5, 2025 17:56
@V00D00-child V00D00-child requested review from a team, mathieuartu and mirceanis May 5, 2025 17:56
@V00D00-child V00D00-child force-pushed the bump-message-signing-snap-to-v1.1.2 branch from 28d85b7 to 899d1ad Compare May 6, 2025 15:20
@github-project-automation github-project-automation bot moved this to Needs dev review in PR review queue May 6, 2025
@V00D00-child V00D00-child removed the status in PR review queue May 6, 2025
@V00D00-child V00D00-child removed the request for review from mathieuartu May 6, 2025 15:36
@V00D00-child V00D00-child force-pushed the bump-message-signing-snap-to-v1.1.2 branch from 899d1ad to dc71b55 Compare May 6, 2025 19:11
@V00D00-child V00D00-child enabled auto-merge May 6, 2025 20:58
github-merge-queue bot pushed a commit to MetaMask/metamask-extension that referenced this pull request May 6, 2025
## **Description**

This is a version bump for the preinstalled
@metamask/message-signing-snap to v1.1.2

This latest version updates the `message signing snap` `endowment:rpc`
to allow requests from a Snap and adds
[npm:@metamask/gator-permissions-snap](https://www.npmjs.com/package/@metamask/gator-permissions-snap/v/0.2.1)
to `initialConnections`.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/32521?quickstart=1)

## **Related issues**

relates to: MetaMask/message-signing-snap#128
required by: MetaMask/snap-7715-permissions#84
relates to: MetaMask/metamask-mobile#15141

## **Manual testing steps**

No user-facing changes

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@V00D00-child V00D00-child added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 7, 2025
@V00D00-child V00D00-child moved this to Needs dev review in PR review queue May 7, 2025
@V00D00-child V00D00-child force-pushed the bump-message-signing-snap-to-v1.1.2 branch from dc71b55 to 641c019 Compare May 9, 2025 17:23
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 9, 2025

@V00D00-child V00D00-child added this pull request to the merge queue May 29, 2025
auto-merge was automatically disabled May 29, 2025 19:27

Pull Request is not mergeable

Merged via the queue into main with commit e77e112 May 29, 2025
40 checks passed
@V00D00-child V00D00-child deleted the bump-message-signing-snap-to-v1.1.2 branch May 29, 2025 19:43
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2025
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 29, 2025
@metamaskbot metamaskbot added the release-7.48.0 Issue or pull request that will be included in release 7.48.0 label May 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dependencies Pull requests that update a dependency file No QA Needed Apply this label when your PR does not need any QA effort. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.46.0 Issue or pull request that will be included in release 7.46.0 release-7.48.0 Issue or pull request that will be included in release 7.48.0 team-readable-permissions MetaMask Readable Permissions Team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants